src/app/shared/forms/planet-number-validator.directive.ts (fixes #9299) #9303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

Saby-Bishops wants to merge 1 commit into master from codex/update-planet-number-validator-for-typed-forms

Member

Saby-Bishops commented Nov 3, 2025

fixes #9299

Summary

replace the directive's use of UntypedFormControl with typed FormControl and ValidatorFn
add a typed validator that leverages the native element validity while preserving existing validators
keep the immediate validity refresh after registering the validator to ensure current validation state

https://chatgpt.com/codex/tasks/task_e_690900980644832d8338b61cbf41032f


          refactor number validator directive for typed forms

7f9f3b6

Saby-Bishops added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels